[m-rev.] for review:

[Julien Fischer]

On Mon, 31 Jul 2006, Peter Wang wrote:

> On 2006-07-31, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>>
>> On Fri, 28 Jul 2006, Zoltan Somogyi wrote:
>>
>>>        PragmaImpl = fc_impl_model_non(LocalVarsDecls, LocalVarsContext,
>>>            FirstCode, FirstContext, LaterCode, LaterContext,
>>>            _Treatment, SharedCode, SharedContext),
>>>        expect(unify(ExtraArgs, []), this_file,
>>>            "ml_gen_goal_expr: extra args"),
>>> +        require(unify(MaybeTraceRuntimeCond, no),
>>> +            "ml_gen_goal_expr: MaybeTraceRuntimeCond"),
>>
>> You should call expect/3 rather than require/2 here.
>
> There was a typo.  I've committed this:
>
> diff -u -r1.182 ml_code_gen.m
> --- compiler/ml_code_gen.m      31 Jul 2006 03:13:43 -0000      1.182
> +++ compiler/ml_code_gen.m      31 Jul 2006 03:49:41 -0000
> @@ -2267,7 +2267,7 @@
>         PragmaImpl = fc_impl_import(Name, HandleReturn, Vars, _Context),
>         expect(unify(ExtraArgs, []), this_file,
>             "ml_gen_goal_expr: extra args"),
> -        extra(unify(MaybeTraceRuntimeCond, no), this_file,
> +        expect(unify(MaybeTraceRuntimeCond, no), this_file,
>             "ml_gen_goal_expr: MaybeTraceRuntimeCond"),
>         ForeignCode = string.append_list([HandleReturn, " ",
>             Name, "(", Vars, ");"]),


Thanks for that Peter.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------