[m-rev.] for review: remove --no-common-goal from documented options

Samrith UONG samuong at gmail.com
Wed Jan 25 15:09:12 AEDT 2006


For review by anyone.

Estimated hours taken: 0.2

Removed --no-common-goal from the documented options.

compiler/options.m and doc/user_guide.texi:
        As this option changes the determinism of some predicates, it can
        cause a correct program not to compile.  This option should not
        used by users in general.

Index: compiler/options.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/options.m,v
retrieving revision 1.489
diff -u -r1.489 options.m
--- compiler/options.m	11 Jan 2006 07:11:01 -0000	1.489
+++ compiler/options.m	25 Jan 2006 02:39:58 -0000
@@ -3872,12 +3872,18 @@
         "\tslow compilation.",
         "--no-common-struct",
         "\tDisable optimization of common term structures.",
+/*
+	Common goal optimization should not be turned off, since it can
+	break programs that would otherwise compile properly (e.g.,
+	benchmarks/icfp2000).  This is kept as a developer-only option.
+
         "--no-common-goal",
         "\tDisable optimization of common goals.",
         "\tAt the moment this optimization",
         "\tdetects only common deconstruction unifications.",
         "\tDisabling this optimization reduces the class of predicates",
         "\tthat the compiler considers to be deterministic.",
+*/
         "--constraint-propagation",
         "\tEnable the constraint propagation transformation,",
         "\twhich attempts to transform the code so that goals",
Index: doc/user_guide.texi
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/doc/user_guide.texi,v
retrieving revision 1.464
diff -u -r1.464 user_guide.texi
--- doc/user_guide.texi	6 Jan 2006 04:06:55 -0000	1.464
+++ doc/user_guide.texi	25 Jan 2006 02:40:32 -0000
@@ -6959,15 +6959,15 @@
 @findex --common-struct
 Disable optimization of common term structures.

- at sp 1
- at item --no-common-goal
- at findex --no-common-goal
- at findex --common-goal
-Disable optimization of common goals.
-At the moment this optimization
-detects only common deconstruction unifications.
-Disabling this optimization reduces the class of predicates
-that the compiler considers to be deterministic.
+ at c @sp 1
+ at c @item --no-common-goal
+ at c @findex --no-common-goal
+ at c @findex --common-goal
+ at c Disable optimization of common goals.
+ at c At the moment this optimization
+ at c detects only common deconstruction unifications.
+ at c Disabling this optimization reduces the class of predicates
+ at c that the compiler considers to be deterministic.

 @item --constraint-propagation
 @findex --constraint-propagation

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list