[m-rev.] for review: analysis framework (2/2)

[Julien Fischer]

On Tue, 17 Jan 2006, Julien Fischer wrote:

> > Index: compiler/hlds_module.m
> > ===================================================================
> > RCS file: /home/mercury1/repository/mercury/compiler/hlds_module.m,v
> > retrieving revision 1.127
> > diff -u -r1.127 hlds_module.m
> > --- compiler/hlds_module.m	28 Nov 2005 04:11:42 -0000	1.127
> > +++ compiler/hlds_module.m	5 Jan 2006 00:37:17 -0000
> > @@ -107,7 +107,7 @@
> >      % Map from proc to an indication of whether or not it
> >      % modifies the trail.
> >      %
> > -:- type trailing_info == map(pred_proc_id, trailing_status).
> > +:- type trailing_info == map(pred_proc_id, {trailing_status, analysis_status}).
>
> I suggest: s/maybe(analysis_status)/
>
> I suggest making that maybe(analysis_status).  In fact rather than
> having a tuple there it would be preferable to have a du type for it,
> e.g.
>
> 	:- type proc_trailing_info
> 		--->	proc_trailing_info(
> 				proc_trailing_status :: trailing_status,
> 				proc_analysis_status :: analysis_status
> 			).
>
> That may mean that some of the fields of the proc_result type may need
> to be renamed.

That's probably a bit confusing; what I meant was something along the
lines of:

:- type proc_trailing_info
	--->	proc_trailing_info(
			proc_trailing_status       :: trailing_status,
			proc_maybe_analysis_status :: maybe(analysis_status)
		).

And then the trailing_info table would be defined as:

:- type trailing_info == map(pred_proc_id, proc_trailing_info).

Cheers,
Julien.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------