[m-rev.] for review: add --lib-linkage option

[Julien Fischer]

On Fri, 6 Jan 2006, Peter Wang wrote:

> Estimated hours taken: 3
> Branches: main
>
> Add a `--lib-linkage' accumulating option for `mmc --make'.  This option
> allows you to specify whether libraries should be installed for shared
> linking (`shared') or static linking (`static').  The option corresponds
> to a options file or environment variable called `LIB_LINKAGES'.

s/an/a/

> compiler/options.m:
> compiler/options_file.m:
> doc/user_guide.texi:
> 	Add and document `--lib-linkage' option and `LIB_LINKAGES'
> 	variable.
>
> 	Unrelated change: document `--no-libgrade' option.
>
> compiler/handle_options.m:
> 	If no --lib-linkage option has been specified, default to the
> 	set of all possible linkages.
>
> compiler/make.program_target.m:
> 	Skip building/installing static or shared libraries according to
> 	the `--lib-linkage' options.
>

...

> Index: compiler/options.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/options.m,v
> retrieving revision 1.487
> diff -u -r1.487 options.m
> --- compiler/options.m	3 Jan 2006 04:07:50 -0000	1.487
> +++ compiler/options.m	5 Jan 2006 23:21:17 -0000
> @@ -735,6 +735,7 @@
>      ;       mercury_configuration_directory_special
>      ;       install_command
>      ;       libgrades
> +    ;       lib_linkages
>      ;       flags_file
>      ;       options_files
>      ;       config_file
> @@ -1458,6 +1459,7 @@
>      mercury_configuration_directory     -   maybe_string(no),
>      install_command                     -   string("cp"),
>      libgrades                           -   accumulating([]),
> +    lib_linkages                        -   accumulating([]),
>      flags_file                          -   file_special,
>      options_files                       -   accumulating(["Mercury.options"]),
>
> @@ -2198,6 +2200,7 @@
>  long_option("use-symlinks",         use_symlinks).
>  long_option("library-grade",        libgrades).
>  long_option("libgrade",             libgrades).
> +long_option("lib-linkage",          lib_linkages).

I suggest also adding --library-linkage as a synonym for the above.

The rest looks fine.  Thanks for that.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------