[m-rev.] diff: improve formatting of some error messages
Peter Moulder
Peter.Moulder at infotech.monash.edu.au
Tue Feb 28 15:00:49 AEDT 2006
On Mon, Feb 27, 2006 at 04:52:04PM +1100, Julien Fischer wrote:
> --- compiler/error_util.m 17 Nov 2005 15:57:09 -0000 1.45
> +++ compiler/error_util.m 27 Feb 2006 01:15:00 -0000
...
> @@ -85,10 +85,13 @@
> ; nl % Insert a line break if there has been text
> % output since the last line break.
>
... ; ...
> % Act as nl, but also add the given integer
> % (which should be a small positive or negative
> - % integer) to the current indent level.
> + % integer) to the current indent level
> +
Minor: Removing the full stop is wrong here.
> + words("itself negatively. This can cause problems for bottom"),
> + words("up evaluation of the predicate/function.")
Another minor issue (inherited from the previous code):
According to a google search for `"bottom up evaluation" logic', it's
usually written `bottom-up evaluation' (with hyphen) -- which is slightly
easier to parse.
I didn't spot any more serious problems in the patch.
pjrm.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list