[m-rev.] for review: preparing promise_equivalent_solutions extension

[Julien Fischer]

On Fri, 24 Feb 2006, Zoltan Somogyi wrote:

> Index: compiler/assertion.m
> ===================================================================
> RCS file: /home/mercury/mercury1/repository/mercury/compiler/assertion.m,v
> retrieving revision 1.44
> diff -u -b -r1.44 assertion.m
> --- compiler/assertion.m	23 Feb 2006 09:36:48 -0000	1.44
> +++ compiler/assertion.m	24 Feb 2006 02:25:17 -0000
> @@ -15,7 +15,7 @@
>
>  %-----------------------------------------------------------------------------%
>
> -:- module hlds__assertion.
> +:- module hlds.assertion.
>  :- interface.
>
>  :- import_module hlds.hlds_data.
> @@ -29,15 +29,15 @@
>
>      % Get the hlds_goal which represents the assertion.
>      %
> -:- pred assertion__goal(assert_id::in, module_info::in, hlds_goal::out) is det.
> +:- pred goal(assert_id::in, module_info::in, hlds_goal::out) is det.
>

That wasn't a very good predicate name to begin with and removing the
module qualifier has just made matters worse.  I suggest calling it
get_assertion_goal, or assertion_goal or something along those lines.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------