[m-rev.] for review: extra_info sections in .analysis files

[Peter Wang]

On 2006-02-17, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> >
> > @@ -55,6 +96,7 @@
> >  %
> >  % version_number.
> >  % module_status.
> > +% extra_info(key, extra_info).
> 
> Perhaps the name of the compiler that wrote the extra_info ought
> to be included as well.
> 
> 	extra_info(compiler_name, key, extra_info).
> 
> Also that definition looks as though it is recursive, so perhaps rewrite
> it as
> 
> 	extra_info(compiler_name, key, extra_data)
> 
> where extra_data is ...
> 
> or something.
> 
> It's probably not worth adding the compiler name to it now (as we
> currently only support mmc anyway) but you should mention it as an XXX.

I didn't think .analysis files would be shared between compilers.

> On the structure fo the .analysis files - are analysis results and
> extra_infos allowed to be interleaved or must all the extra_infos occur
> before the analysis results?  Either way, it isn't clear from that
> comment.
> ...

Before the results.  I'll make it clearer.

> >
> > +:- type extra_info_key == string.
> > +
> > +:- typeclass extra_info(ExtraInfo) <= to_string(ExtraInfo) where [].
> > +
> 
> There should be some comments describing this type and typeclass and
> what their intended purpose is.

Ok.

Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------