[m-rev.] for review: more work on intermodule analysis

Zoltan Somogyi zs at cs.mu.OZ.AU
Thu Feb 2 15:52:01 AEDT 2006


On 02-Feb-2006, Peter Wang <wangp at students.cs.mu.OZ.AU> wrote:
> > > +    analysis__write_analysis_files(mmc, ModuleId, ImportedModuleIds,
> > > +        AnalysisInfo0, AnalysisInfo, !IO),
> > > +    module_info_set_analysis_info(AnalysisInfo, !HLDS).
> > 
> > There's no point in doing that; we're never going to use the analysis_info
> > again after this point.
> 
> Ok.

Maybe we won't use it, but the cost seems minor compared to the potential
surprise for a future compiler developer without that call to
module_info_set_analysis_info.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list