[m-rev.] for review: mercury_opengl changes

[Julien Fischer]

On Tue, 5 Dec 2006, Peter Wang wrote:

> On 2006-12-05, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>>
>> On Tue, 5 Dec 2006, Peter Wang wrote:
>>> extras/graphics/mercury_opengl/mogl.m:
>>> 	Add bindings for glTexImage1D, glTexImage2D, glTexImage3D,
>>> 	glCopyTexImage1D, glCopyTexImage2D.
>>>
>>> 	Move the pixel_data type into the interface.
>>>
>>> 	Import mogl.type_tables.
>>>
>>> extras/graphics/mercury_opengl/mogl.type_tables.m:
>>> 	New module.  This is intended to expose some of the <type>_to_int and
>>> 	<type>_flags[] tables.  Modules other than mogl can import this
>>> 	module
>>> 	to convert mogl types to their equivalent OpenGL constants.
>>
>> Is this a particularly useful thing to be able to do?
>
> In my case I'm using a separate library to load textures, and it accepts
> OpenGL texture format flags.

Fair enough.

>>> +:- pred texture_format_to_int(texture_format, int).
>>> +:- mode texture_format_to_int(in, out) is det.
>>> +%:- mode texture_format_to_int(out, in) is semidet.
>>
>> Why is that mode commented out?
>
> I just copied it verbatim from mogl.m.

Hmmm ... then it would have been me who commented it out.
(I wonder what it was for?)

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------