[m-rev.] For review: pretty print c_pointers as addresses

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Aug 22 12:46:06 AEST 2006


On Tue, 22 Aug 2006, Mark Brown wrote:

> Estimated hours taken: 2
> Branches: main
>
> runtime/mercury_ml_expand_body.h:
> 	Construct strings representing c_pointer addresses.  Used in the
> 	implementation of functor and deconstruct.
>
> library/deconstruct.m:
> 	Document the behaviour of functor and deconstruct for c_pointers.
>
> library/string.m:
> 	Export c_pointer_to_string for getting a string representation
> 	of the pointer address.
>
For consistency with the rest of the library I would add
string.from_c_pointer as a synonym.

> library/io.m:
> library/rtti_implementation.m:
> 	Use c_pointer_to_string/1 to print c_pointers.
>
> 	Update comments.
>
> library/pprint.m:
> 	Undo Ralph's earlier change, since it is no longer required.
>
> tests/debugger/Mmakefile:
> tests/debugger/declarative/Mmakefile:
> 	Canonicalize the output of test cases in which c_pointers appear.
>
> tests:
> 	Update the expected output of test cases.
>
Looks good otherwise.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list