[m-rev.] for review: remove support for `thread_safe' mutable attribute

Ralph Becket rafe at csse.unimelb.edu.au
Mon Aug 14 16:58:06 AEST 2006


Julien Fischer, Monday, 14 August 2006:
> 
> For review by Peter or Ralph (still pending bootcheck)
> 
> The following is in response to a thread on a mercury-developers and
> also to some discussions in person with Peter Wang and Ralph.  The
> problem is that the existing `thread_safe' attribute on mutables is
> fairly much not thread safe.  This diff removes the dodgy behaviour,
> although it's not ideal as all mutable now share the same global mutex
> as other non-thread-safe foreign code.
> 
> Estimated hours taken: 1
> Branches: main, release
> 
> Get rid of the `thread_safe' mutable attribute, since this doesn't actually
> make access to a mutable thread safe (in fact it makes them less thread
> safe than the `not_thread_safe' version).
> 
> By extension this also removes support for the `not_thread_safe' mutable
> attribute.

That looks fine to me.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list