[m-rev.] for review: fix `:- mutable' decls and sub-modules

Julien Fischer juliensf at cs.mu.OZ.AU
Thu Sep 15 16:42:40 AEST 2005


On Thu, 15 Sep 2005, Julien Fischer wrote:

> compiler/modules.m:

> 	Order the items in private interface files.
>

Actually, that turned out to be a bad idea.  The code that constructs private
interfaces is quite delicate and filtering out the mutables reversed the order
of the items - I was hoping that standardising the order as we do with the
other interface files would sort out any problems but the code that sorts
interface items doesn't handle lists of items that represent private
interfaces particularly well at the moment (the problem is most likely the
lacke of interface and implmentation decls in the item list at that point).

I'll take a separate look at this code and try to make it a little
more robust than it apparently is - in the meantime I've removed the
order_items call, reversed the item list after processing mutables
and put an XXX comment there.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list