[m-rev.] for review/diff: update and cleanup test_mercury script

Mark Brown mark at cs.mu.OZ.AU
Wed Sep 14 13:39:37 AEST 2005


On 14-Sep-2005, Mark Brown <mark at cs.mu.OZ.AU> wrote:
> Estimated hours taken: 0.5
> Branches: main
> 
> tools/test_mercury:
> 	Undo a recent change to the part of this script which makes a backup
> 	of the current installation.  The previous change was to `mv' the
> 	installation into the backup directory instead of `cp'ing it.  The
> 	purpose of this was to save disk space.  Unfortunately, this doesn't
> 	work because later commands, which use mmake, need to use an mmake
> 	which is configured for the machine in question.
> 
> 	The disk space issue is not so serious now because we have freed up
> 	space on ceres.  We may need to reinstate the earlier change if space
> 	becomes a problem again, but it will need to be done more cleverly.

I meant to update the comment above that piece of code as well:

Estimated hours taken: 0.1
Branches: main

tools/test_mercury:
	Expand a comment relating to my previous change.

Index: tools/test_mercury
===================================================================
RCS file: /home/mercury1/repository/mercury/tools/test_mercury,v
retrieving revision 1.257
diff -u -r1.257 test_mercury
--- tools/test_mercury	14 Sep 2005 03:22:20 -0000	1.257
+++ tools/test_mercury	14 Sep 2005 03:25:45 -0000
@@ -677,7 +677,8 @@
     esac
 
     # Make a backup copy of the current installation which we will restore
-    # if the new installation fails.
+    # if the new installation fails.  Note that we use `cp' here and not `mv',
+    # since later commands will still want to use the current installation.
 
     BACKUP_DIR=`dirname $INSTALL_DIR`/mercury_install_backup
     mkdir -p $BACKUP_DIR
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list