[m-rev.] diff/for review: last call modulo construction

Ralph Becket rafe at cs.mu.OZ.AU
Mon Sep 12 16:38:44 AEST 2005


Zoltan Somogyi, Monday, 12 September 2005:
> We have been missing this optimization for a long time. Now we ought to
> get significantly better results on some standard benchmarks such as
> naive reverse. However, the impact on the compiler performance in general
> is not as good. My preliminary benchmarking shows that the new optimization
> gives a 2% speedup at -O2, but slowdowns at higher optimization levels.
> This must be due to an unfavourable interaction with some other optimization.
> I will look into this later.

I've looked over the diff and it looks good to me, although I only gave
the low-level code generation parts a cursory glance because I'm not
very familiar with that aspect of the compiler.  It may be worth taking
Peter's suggestion into account re: zeroing the fields to be set by
reference.

-- Ralph
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list