[m-rev.] For review: added any_list, any_map, any_array, any_assoc_list to extras

[Julien Fischer]

On Fri, 9 Sep 2005, Ralph Becket wrote:

> Estimated hours taken: 24
>
> Add list, map, assoc_list, and array ADTs for collections of solver type
> values.
>
> extras/solver_types:
> extras/solver_types/library:
> extras/solver_types/library/Mmakefile:
> extras/solver_types/library/any.m:
> extras/solver_types/library/any_map.m:
> extras/solver_types/library/any_array.m:
> extras/solver_types/library/any_tree234.m:
> extras/solver_types/library/any_assoc_list.m:
> extras/solver_types/library/any_list.m:
> 	Added.
>
> extras/solver_types/library/any_util.m:
> 	Defines unsafe_cast_to_ground/1 which is used very carefully
> 	in any_{map,tree234,assoc_list}.m to cast polymorphic key
> 	values from inst any to ground.  This is necessary because
> 	the code needs to compare key values, but they have a polymorphic type
> 	and the compiler cannot statically infer that any = ground for
> 	polymorphically typed variables.
>
You also need to update extras/README.

> Index: extras/solver_types/library/Mmakefile
> ===================================================================
> RCS file: extras/solver_types/library/Mmakefile
> diff -N extras/solver_types/library/Mmakefile
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ extras/solver_types/library/Mmakefile	9 Sep 2005 05:57:47 -0000
> @@ -0,0 +1,21 @@
> +#-----------------------------------------------------------------------------#
> +# Copyright (C) 2000, 2002-2003 The University of Melbourne.
> +# This file may only be copied under the terms of the GNU Library General
> +# Public License - see the file COPYING.LIB in the Mercury distribution.
> +#-----------------------------------------------------------------------------#
> +
The years are wrong in the copyright messages and on the other files as
well (unless you started working on any_arrays in 1993).

That looks fine otherwise.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------