[m-rev.] for review: check that abstract type declarations have definitions

Fergus Henderson fjh at cs.mu.OZ.AU
Tue May 10 19:43:17 AEST 2005


On 22-Apr-2005, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> 
> compiler/gcc.m:
> 	Comment an abstract type declaration that does not have
> 	a corresponding definition.
...
> Index: compiler/gcc.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/gcc.m,v
> retrieving revision 1.32
> diff -u -r1.32 gcc.m
> --- compiler/gcc.m	24 Mar 2005 02:00:25 -0000	1.32
> +++ compiler/gcc.m	21 Apr 2005 08:18:14 -0000
> @@ -184,7 +184,10 @@
>  %
> 
>  % A GCC `tree' representing a declaration.
> -:- type gcc__decl.
> +% XXX This doesn't have a definition and appears to be unused anyway.
> +% - juliensf
> +%
> +%:- type gcc__decl.

The appropriate definition for that type is

	:- type gcc__decl == gcc__tree.

(in the implementation section of the module).
But it would also be OK to just delete it.

-- 
Fergus Henderson                    |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list