[m-rev.] for review: make pred names for lambdas unique

Ian MacLarty maclarty at cs.mu.OZ.AU
Wed May 25 16:05:15 AEST 2005


On Wed, 25 May 2005, Zoltan Somogyi wrote:

> > +		lambdas_per_context		:: map(prog_context, counter),
> > +						% How many lambda expressions
> > +						% there are at different
> > +						% contexts in the module.
> > +						% This is used to uniquely
> > +						% identify lambda expression
> > +						% that appear on the same
> > +						% line of the same file.
>
> s/expression/expressions/
>

Fixed.

> > +module_info_next_lambda_count(Context, Count, MI0, MI) :-
> > +	module_info_get_lambdas_per_context(MI0, ContextCounter0),
> > +	(
> > +		map.insert(ContextCounter0, Context, counter.init(2),
> > +			FoundContextCounter)
> > +	->
> > +		Count = 1,
> > +		ContextCounter = FoundContextCounter
> > +	;
> > +		map.lookup(ContextCounter0, Context, Counter0),
> > +		counter.allocate(Count, Counter0, Counter),
> > +		map.set(ContextCounter0, Context, Counter, ContextCounter)
> > +	),
> > +	module_info_set_lambdas_per_context(ContextCounter, MI0, MI).
>
> s/map.set/map.det_update/
>

Done.

> >  tests/debugger/declarative/ho2.exp2:
> >  tests/debugger/declarative/trust.exp:
> >  tests/hard_coded/deconstruct_arg.exp:
> > -	Expect the new unique predicate names.
> > +	Expect the new (more) unique predicate names.
>
> I expect some of the .exp* files also need updating, but otherwise,
> the diff is fine.
>

Yes they did.  I'm still bootchecking in all the debug grades to make sure
I pick up all the new expected outputs.

Cheers,

Ian.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list