[m-rev.] first step toward functional dependencies (3/3)
Julien Fischer
juliensf at cs.mu.OZ.AU
Wed Mar 30 14:46:52 AEST 2005
On Wed, 23 Mar 2005, Mark Brown wrote:
> Index: compiler/unused_args.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/unused_args.m,v
> retrieving revision 1.102
> diff -u -r1.102 unused_args.m
> --- compiler/unused_args.m 22 Mar 2005 06:40:31 -0000 1.102
> +++ compiler/unused_args.m 22 Mar 2005 12:23:48 -0000
> @@ -1062,11 +1062,13 @@
> pred_info_get_class_context(!.PredInfo, ClassContext),
> pred_info_get_aditi_owner(!.PredInfo, Owner),
> map__init(EmptyProofs),
> + map__init(EmptyConstraintMap),
It's probably worth adding a comment there about why it's okay
for the contraint map to be empty.
> Origin = transformed(unused_argument_elimination(UnusedArgs),
> OrigOrigin, PredId),
> pred_info_init(PredModule, Name, Arity, PredOrFunc, Context, Origin,
> Status, GoalType, Markers, ArgTypes, Tvars, ExistQVars,
> - ClassContext, EmptyProofs, Owner, ClausesInfo, !:PredInfo),
> + ClassContext, EmptyProofs, EmptyConstraintMap, Owner,
> + ClausesInfo, !:PredInfo),
> pred_info_set_typevarset(TypeVars, !PredInfo).
>
This change is otherwise okay. Assuming that it bootstraps
in a couple of grades you can go ahead and commit it.
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list