[m-rev.] diff: cleanup module_qual and middle_rec

[Zoltan Somogyi]

On 21-Mar-2005, Ralph Becket <rafe at cs.mu.OZ.AU> wrote:
> > @@ -1,4 +1,4 @@
> >  cyclic_typeclass.m:030: Error: cyclic superclass relation detected:
> > -cyclic_typeclass.m:030:   `cyclic_typeclass.bar/1' <= `cyclic_typeclass.foo/1'
> > -cyclic_typeclass.m:030:   <= `cyclic_typeclass.bar/1'
> > +cyclic_typeclass.m:030:   `cyclic_typeclass.bar'/1 <= `cyclic_typeclass.foo'/1
> > +cyclic_typeclass.m:030:   <= `cyclic_typeclass.bar'/1
> >  For more information, try recompiling with `-E'.
> 
> Personally, I think if you're going to change the quoting, you should
> get rid of it altogether here.  Moving the arity outside the quotes
> makes these error messages less readable, IMO.

I don't want to argue for the quotes; they were Fergus's idea, not mine.
However, we do want to be consistent, putting quotes in the same places
around sym_names in all error messages.

One idea would be to have error_util check whether the sym_name contains
any non-alphanumeric characters other than ".", and put quotes around
sym_names only if there are some. Now that many parts of the compiler
all use error_util to generate those parts of messages, this can be done
centrally. Any opinions, one way or another?

However, either way, any change is for another diff.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------