[m-rev.] diff/for review: fix hlc.agc grade

[Julien Fischer]

On Fri, 28 Jan 2005, Julien Fischer wrote:

> Estimated hours taken: 7
> Branches: main
>
> Workaround a problem in the hlc.agc grade that were caused by
> the recent changes to ml_code_util.m.
>
> compiler/ml_code_util.m:
> 	Start the func_label counter in the ml_gen_info structure
> 	at 1 rather than 0 in order to avoid off-by-one errors
> 	in the code that performs the shadow stack transformation
> 	for accurate gc.  The problem eventually manifests itself
> 	in the generated code as two separate C functions that
> 	have the same name.
>
> 	Add an XXX comment about the above.
>
> 	Put the variables that in initialise the ml_gen_info structure
> 	in the ml_gen_info_init function in the correct order.  The
> 	compiler did not pick this up because all of the ones that
> 	were out of order have the same type.
>
> compiler/ml_elim_nested.m:
> 	Reorder some code so that it follows the natural data flow and
> 	readers don't have to mentally perform mode analysis to work
> 	out what is going on.
>

I've committed this on the main branch, I'll also commit it on the
release branch - I'll have the nightly tests build and test hlc.agc after
this change has bootstrapped.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------