[m-rev.] for review: print lists on breakpoints

Zoltan Somogyi zs at cs.mu.OZ.AU
Fri Jan 28 14:02:10 AEDT 2005


On 28-Jan-2005, Ian MacLarty <maclarty at cs.mu.OZ.AU> wrote:
> s/brakpoint/breakpoint/

Done.

> > +            /*
> > +            ** We ignore the print_list computed here, because we want to
> > +            ** execute the print list of a matched spy point even if the event
> > +            ** is the end event of a command. In that case, the code above
> 
> I don't understand when an event would be the "end event of a command".
> Are you sure this is what you wanted to say here?

For the command "goto 30", event 30 is the end event of the command.
Would "target event of a forward movement command" be better?

> > +        if (point->spy_print_list != NULL) {
> > +            /* XXX */
> 
> What's this XXX for?

To remind me to add the code for saving breakpoints' print lists for the "save"
mdb command. I wrote the code last night and committed it a few minutes ago.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list