[m-rev.] for review: fix debugger namespace cleanliness

Julien Fischer juliensf at cs.mu.OZ.AU
Sat Jan 22 16:57:56 AEDT 2005


On Sat, 22 Jan 2005, Ian MacLarty wrote:

> On Sat, Jan 22, 2005 at 01:47:45AM +1100, Julien Fischer wrote:
> >
> > For post-commit review by Ian.
> >
> > (I committed this because it's breaking the nightly builds
> >  on ceres and almery.)
> >
> > Estimated hours taken: 1
> > Branches: main
> >
> > The namespace cleanliness check in the browser directory
> > has been failing in the high-level C grades.  This is
> > because the symbols exported from term_rep did not have
> > one of the expected prefixes.  Fix this by making term_rep
> > part of the mdb package.
> >
>
> I didn't make it part of the mdb package because it's a fairly general
> purpose module.  That looks fine what you've done, but what's the
> reason you didn't just add "term_rep" to the list of expected prefixes?
>
There's no point in polluting the namespace more than necessary -
I just wanted a quick workaround for the problem, I was going to
leave whatever needs to be done in the long run to you.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list