[m-rev.] for review: fix debugger namespace cleanliness
Julien Fischer
juliensf at cs.mu.OZ.AU
Sat Jan 22 01:47:45 AEDT 2005
For post-commit review by Ian.
(I committed this because it's breaking the nightly builds
on ceres and almery.)
Estimated hours taken: 1
Branches: main
The namespace cleanliness check in the browser directory
has been failing in the high-level C grades. This is
because the symbols exported from term_rep did not have
one of the expected prefixes. Fix this by making term_rep
part of the mdb package.
browser/mdb.m:
browser/term_rep.m:
Make the term_rep module part of the mdb package.
browser/declarative_debugger.m:
browser/declarative_execution.m:
browser/declarative_user.m:
Conform to the above change.
Julien.
Index: declarative_debugger.m
===================================================================
RCS file: /home/mercury1/repository/mercury/browser/declarative_debugger.m,v
retrieving revision 1.47
diff -u -r1.47 declarative_debugger.m
--- declarative_debugger.m 19 Jan 2005 02:43:36 -0000 1.47
+++ declarative_debugger.m 21 Jan 2005 14:31:15 -0000
@@ -62,7 +62,7 @@
:- import_module mdbcomp__program_representation.
:- import_module mdb.browser_info.
-:- import_module term_rep.
+:- import_module mdb.term_rep.
:- import_module io, list, std_util, string.
Index: declarative_execution.m
===================================================================
RCS file: /home/mercury1/repository/mercury/browser/declarative_execution.m,v
retrieving revision 1.32
diff -u -r1.32 declarative_execution.m
--- declarative_execution.m 19 Jan 2005 03:10:17 -0000 1.32
+++ declarative_execution.m 21 Jan 2005 14:31:59 -0000
@@ -19,10 +19,11 @@
:- interface.
:- import_module mdb__util.
+:- import_module mdb.term_rep.
:- import_module mdbcomp__prim_data.
:- import_module mdbcomp__program_representation.
-:- import_module list, std_util, io, bool, term_rep.
+:- import_module list, std_util, io, bool.
% This type represents a port in the annotated trace.
% The type R is the type of references to other nodes
Index: declarative_user.m
===================================================================
RCS file: /home/mercury1/repository/mercury/browser/declarative_user.m,v
retrieving revision 1.37
diff -u -r1.37 declarative_user.m
--- declarative_user.m 19 Jan 2005 03:10:17 -0000 1.37
+++ declarative_user.m 21 Jan 2005 14:32:28 -0000
@@ -74,8 +74,7 @@
:- import_module mdbcomp__prim_data.
:- import_module mdbcomp__program_representation.
:- import_module mdb.parse.
-
-:- import_module term_rep.
+:- import_module mdb.term_rep.
:- import_module std_util, char, string, bool, int, deconstruct, getopt, list.
Index: mdb.m
===================================================================
RCS file: /home/mercury1/repository/mercury/browser/mdb.m,v
retrieving revision 1.15
diff -u -r1.15 mdb.m
--- mdb.m 19 Nov 2004 11:54:17 -0000 1.15
+++ mdb.m 21 Jan 2005 14:29:38 -0000
@@ -39,6 +39,7 @@
:- include_module set_cc.
:- include_module tree234_cc.
+:- include_module term_rep.
% XXX these modules are more generally useful, but the
% dynamic linking library is not yet installed anywhere.
Index: term_rep.m
===================================================================
RCS file: /home/mercury1/repository/mercury/browser/term_rep.m,v
retrieving revision 1.1
diff -u -r1.1 term_rep.m
--- term_rep.m 19 Jan 2005 02:43:37 -0000 1.1
+++ term_rep.m 21 Jan 2005 14:29:53 -0000
@@ -15,7 +15,7 @@
% and don't care about it's actual value.
%
-:- module term_rep.
+:- module mdb.term_rep.
:- interface.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list