[m-rev.] for review: remove unnecessary imports from .int files

Julien Fischer juliensf at cs.mu.OZ.AU
Fri Jan 21 14:13:56 AEDT 2005


On Fri, 21 Jan 2005, Ralph Becket wrote:

> > Break up check_hlds.type_util so that predicates that do
> > not require access to the HLDS are placed in a new module,
> > parse_tree.prog_type.  The above change requires some of
> > requires some of these predicates.  This also removes one
>
> "requires some of" is duplicated.
>
Fixed.

...

> > Modify the parser so that import_module declarations
> > that specify more than one module are replaced by multiple
> > import_module declarations, with one module per declaration.
> > This makes the above change easier to implement and is in
> > any case required by the upcoming diff for canonicalizing
> > module interfaces.  We also doe the same for use_module and
>
> s/doe/do/
>
Fixed.

...

> > include_module declarations.
>
> > +	% strip_unnecessary_impl_imports(NecssaryModules, !Items).
> > +	%
> > +	% Remove all import_module and use_module declarations for
> > +	% modules that are not in `NecessaryModules',
> > +	%
> > +	% NOTE: This will only work if each item corresponding
> > +	% to an import_module or use_module declaration only imports
> > +	% a single module.  (This should be the case, see prog_io.m.)
>
> s/This/this/ - only Americans capitalise after a colon.
>
It's now lowercase.

Thanks Ralph,

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list