[m-rev.] for review: handle EXCP nodes in wrong and missing answer diagnosis

[Ian MacLarty]

On 19 Jan 2005, at 03:14, Mark Brown wrote:

>> Index: browser/declarative_tree.m
>> ===================================================================
>> RCS file: 
>> /home/mercury1/repository/mercury/browser/declarative_tree.m,v
>> retrieving revision 1.14
>> diff -u -r1.14 declarative_tree.m
>> --- browser/declarative_tree.m	18 Jan 2005 03:56:51 -0000	1.14
>> +++ browser/declarative_tree.m	18 Jan 2005 14:08:48 -0000
>> @@ -293,11 +294,12 @@
>>  	get_edt_call_node(Store, Ref, CallId),
>>  	\+ not_at_depth_limit(Store, CallId).
>>
>> -:- pred trace_weight(wrap(S)::in, edt_node(R)::in, int::out, 
>> int::out)
>> -	is det <= annotated_trace(S, R).
>> +:- pred trace_weight(wrap(S)::in, edt_node(R)::in, int::out,
>> +	int::out) is det <= annotated_trace(S, R).
>>
>>  trace_weight(Store, NodeId, Weight, ExcessWeight) :-
>> -	node_events(Store, NodeId, 0, Weight, no, 0, 0, ExcessWeight).
>> +	node_events(Store, NodeId, 0, Weight, no, 0, 0,
>> +		ExcessWeight).
>
> These changes aren't necessary.  There's a couple of other formatting
> changes like this, too.

Sorry about that.  I started making some changes to these predicates 
and then changed my mind.  I've reverted these changes so they don't 
appear in the diff.

> Now that I see it in action, this is probably not the right explanation
> for this bug.  What the debugger is saying is that the exception thrown
> by 'throw' was not caught by 'q', but in cases like this the proper
> explanation would probably be that the exception that is being thrown
> is the wrong one.  So the message should be "Found unhandled or 
> incorrect
> exception".
>

I agree.

Thanks,

Ian.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------