[m-rev.] for review: module to read trace counts (2)

[Zoltan Somogyi]

On 14-Jan-2005, Peter Wang <wangp at students.cs.mu.OZ.AU> wrote:
> I think the name mdbcomp__proc_id is just wrong, given what's now inside.
> I can rename it easily at this point with a search & replace on the diff,
> if there are suggestions.

How about mdbcomp__prim_data?

I have a script calles gres (global regular expression substitute) that you
can use.

	~zs/bin/script/gres mdbcomp__proc_id mdbcomp__prim_data *.m

should do the trick.

> Also, I can split the commits in two (one to introduce proc_id.m, then
> another for the trace counts reader) if that would be better.

That won't be necessary.

> +% XXX: This is duplicated in browser/util.m but moving that in here means this
> +% module will need to be imported into most of the debugger, which has a
> +% conflicting definition of module_name.

The right solution that would be to rename every occurrence of "module_name"
that uses mdb's definition to use a different name, maybe "flat_module_name".
You should always avoid duplication of types unless there is no other choice;
that isn't the case here.

> +% XXX: There is an equivalent but different type in browser/util.m.
> +% Trying to make the debugger use this definition instead is troublesome 
> +% because of the conflicting definitions of module_name.

That should fix problems like this.

Otherwise, the diff is fine.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------