[m-rev.] for review: add transform_value predicate to map.

Julien Fischer juliensf at cs.mu.OZ.AU
Wed Jan 12 23:40:37 AEDT 2005


On Wed, 12 Jan 2005, Ian MacLarty wrote:

> > > > >  * We've added a predicate, map_fold, to set.m.
> > > > >
> > > > This doesn't mention the changes to the rbtree module.
> > > >
> > >
> > > Is that news worthy?  Or is every change to the library supposed to go into the
> > > NEWS file?
> > >
> > I think it's worth mentioning.
> >
>
> Okay:
>
> * We've added a predicate, rbtree__transform_value, to rbtree.m.

There is already a list of addition to the rbtree module in the NEWS
file, just add this to the end of that.

> > > "aborts" is used elsewhere in the module to describe the det versions of
> > > predicates, so I think that convention should be followed for consistency.
> > >
> > I suspect "aborts" originated when calling error/1 really did abort
> > execution - I think saying it throws an exception is probably more
> > accurate now.
> >
>
> I still think it should be "aborts" because otherwise someone reading through
> the module might think "aborting" is something different to "throwing an
> exception".  Otherwise they should all be updated to "throwing an exception"
> which I'm not gonna do now :-)
>
Fair enough.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list