[m-rev.] for review: module to read trace counts

[Julien Fischer]

On Tue, 11 Jan 2005, Peter Wang wrote:

> > > +            default:
> > > +                /* This assumes isalnum is the same as char__isalnum. */
> > > +                if (isalnum(*c) ||
> > > +                    strchr(" !@#$%^&*()-_+=`~{}[];:'\"<>.,/?\\|", *c))
> >
> > Where did that string come from? It looks OK, I am just curious.
>
> It is the equivalent of term_io__is_mercury_punctuation_char.  I'll add a
> comment to that effect.
>
You should probably also add a comment in the term_io module that any
changes to the is_mercury_punctuation_char predicate need to be reflected
here is as well.  Alternatively, you could just export
is_mercury_punctuation_char to C and call it instead of the above.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------