[m-rev.] for review: module to read trace counts

Ian MacLarty maclarty at cs.mu.OZ.AU
Tue Jan 11 15:49:32 AEDT 2005


On Tue, Jan 11, 2005 at 03:10:12PM +1100, Zoltan Somogyi wrote:
> On 11-Jan-2005, Peter Wang <wangp at students.cs.mu.OZ.AU> wrote:
> > This adds a module libs__trace_counts that reads in the .mercury_trace_counts
> > files produced by the compiler's trace mechanism.  The format of said files
> > was slightly changed.
> > 
> > compiler/trace_counts.m:
> > 	New module.
> 
> Since the declarative debugger also needs to be able to read trace counts,
> the new module should be in the browser directory, and part of the mdbcomp
> package. Any parts of the compiler, e.g. the trace_port type in trace_params.m,
> that trace_counts.m depends on should also be made part of the mdbcomp package.
> 

Yes.  However trace_counts will need access to the proc_label type, so
I suggest proc_label.m also be moved to browser and included in mdbcomp.
Currently a duplicate type, proc_id, is defined in 
browser/declarative_execution.m, so moving proc_label.m to browser will also
remove the need for this type.

I'm a little unclear myself on what the current standard for module
qualifiers is, though I think for new files it should be `.' and not `__'.
Can someone else confirm this please?

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list