[m-rev.] for review: add --resume dd option

[Ian MacLarty]

On Thu, Feb 24, 2005 at 04:32:37PM +1100, Julien Fischer wrote:
> 
> 
> On Thu, 24 Feb 2005, Ian MacLarty wrote:
> 
> Do you need to update the user guide as well?
> 

Yes I do:

Index: doc/user_guide.texi
===================================================================
RCS file: /home/mercury1/repository/mercury/doc/user_guide.texi,v
retrieving revision 1.422
diff -u -r1.422 user_guide.texi
--- doc/user_guide.texi	24 Feb 2005 00:35:28 -0000	1.422
+++ doc/user_guide.texi	24 Feb 2005 06:28:14 -0000
@@ -3312,7 +3312,7 @@
 @ref{Declarative debugging} for details.
 @sp 1
 @table @code
- at item dd [-d at var{depth}] [-s at var{search-mode}]
+ at item dd [-r] [-d at var{depth}] [-s at var{search-mode}]
 @c @item dd [--assume-all-io-is-tabled]
 @c The --assume-all-io-is-tabled option is for developers only. Specifying it
 @c makes an assertion, and if the assertion is incorrect, the resulting
@@ -3329,12 +3329,22 @@
 declarative debugger for long running programs since it will not have to rerun
 the program as much.
 @sp 1
-The @samp{-s at var{search-mode}} or @samp{--search-mode
- at var{search-mode}} option tells the declarative debugger which 
+The @samp{-s at var{search-mode}} or @samp{--search-mode @var{search-mode}} 
+option tells the declarative debugger which 
 search mode to use.  Either @samp{top-down} or @samp{divide-and-query}
 may be specified.  See @ref{Search Modes} for a more detailed description of
 the available search modes.  @samp{top-down} is the default when this option is
 not given.
+ at sp 1
+Give the @samp{-r} or @samp{--resume} option to continue your previous
+declarative debugging session.  This option should only be given if a 
+ at samp{dd} command was previously issued without the @samp{--resume} option.  If
+the @samp{--resume} option is given and there were no previous declarative
+debugging sessions then the option will be ignored.  
+A @samp{dd --resume} command can be issued at any event.
+The @samp{--search-mode} or @samp{--depth-step-size} options can be used in
+conjunction with the @samp{--resume} option to change the search mode or depth
+step size of a previously started declarative debugging session.
 @sp 1
 @item trust @var{module-name}|@var{proc-spec}
 @kindex trust (mdb command)

> > +diagnosis_new_tree(Store, Node, UseOldIoActionMap, IoActionStart, IoActionEnd,
> > +		Response, !State, !Browser, !IO) :-
> > +	diagnosis(Store, new_tree(dynamic(Node)), UseOldIoActionMap,
> > +		IoActionStart, IoActionEnd, Response, !State, !Browser, !IO).
> > +
> > +	% Export a monomorphic version of diagnosis/10 that requests the
> > +	% continuance of a previously suspended declarative debugging session.
> s/continuance/continuation/
> 

Fixed.

> >  			const char *goal_path, MR_bool context_mismatch);
> >
> > +/*
> > +** Find the first call event in the stack whose event number or sequence number
> s/in the stack/on the stack/
> 

Okay.

> > +/*
> > +** If we are materializing a new subtree then MR_edt_start_seqno is the
> > +** call sequence number of the call at the top the the subtree we want to
> s/the the/of the/
> 

Fixed.

> > +	** Case b) covers the situation where the current event is after the
> > +	** final event for seqno and case a) covers the case where the current
> > +	** event is greater than or equal to the call event for seqno and less
> > +	** than or equal to the final event for seqno.  This means we will do
> > +	** a retry if the call event for seqno is equal to the current event
> > +	** but thats not a problem since the retry will be a no-op.
> s/thats/that's/
> 

Fixed.

> > +		if (ancestor_level >= 0) {
> > +			/*
> > +			** Perform a retry to get to somewhere before the
> 
> "somewhere" is a bit imprecise.
> 

Deleted "somewhere".

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------