[m-rev.] for review: prevent unnecessary recompilations.

Zoltan Somogyi zs at cs.mu.OZ.AU
Thu Feb 24 11:13:25 AEDT 2005


On 24-Feb-2005, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> >      ( type_to_ctor_and_args(Type, TypeCtor, Args) ->
> >          TypeCtor = SymName - _Arity,
> > -        ( sym_name_get_module_name(SymName, ModuleName) ->
> > -            svset.insert(ModuleName, !Modules),
> > -            get_modules_from_types(Args, !Modules)
> > -        ;
> >              (
> > -                type_ctor_is_higher_order(TypeCtor, _, _, _ )
> > +            type_ctor_is_higher_order(TypeCtor, _, _, _)
> >              ->
> The indentation needs fixing here (assuming that it's not CVS or
> my mail reader ;-) )

It is an artifact of cvs diff -b. It eliminates a whole bunch of lines
in which the only difference is the amount of white space, but the this
means that new and changed lines are shown relative the indentation that
surrounding lines *used* to have, as opposed to what they have now. In this
case (and the other one you noted), the diff eliminated one level of nesting
in an if-then-else.

I followed your other suggestions.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list