[m-rev.] For review: new constraint based mode analysis

[Richard James FOTHERGILL]

On Wed, 9 Feb 2005, Ralph Becket wrote:
> No, 79 cols is the *maximum* (unified CVS diffs add a char), and you
> would do well to stick to 72 for documentation.  You can do this easily
> for documentation in Vim with `:set textwidth=72', then use `V' to
> visually highlight what is to be reformatted, then use `gq' to
> automatically reformat.

Done. Thanks.

>
>> I'll see what I can do with the comments. Use of 'conj' not as a child
>> of disj is permitted - even reccomended in the general sense. I was
>> refering to the fact that, when it comes to mode constraints, I've
>> omitted the conj constructor at the top level, and just used the
>> constraint formulae type. Probably I should just remove that part of
>> this comment - while 'conj' was only included because it was needed
>> for use as a child of 'disj', I suppose there's no reason to say so.
>
> Yes!  We only need to know about genuine constraints and invariants.
>

I've deleted the offending comments.


> Agreed.  I think the polymorphism pass responsible for adding the extra
> args should also update the argument mode records.

It looks like they do - now everything works fine without me trying to add
modes for type info arguments.



Cheers,
Richard
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------