[m-rev.] for review: preparing for CTGC system

[Nancy]

Hi,

>>3. I presumed that "long" filenames are preferred over short ones, so I
>>chose filenames reflecting the hierarchy above. Yet I didn't add the
>>"transform_hlds" part to the filenames. It just seemed to become too
>>long in that case.
>>
> 
> 
> There's no particularly policy on long vs. short filenames. I suggest
> you may even want to omit the ctgc part from them as well.

Okay.

>>4. For those who might have ever looked into the reuse-branch: I've
>>replaced the terminology "possible alias" by "data structure sharing" or
>>in short "structure sharing", conforming to the terminology used in my PhD.
>>
>>In attach the log + diff and new files...
> 
> 
> It would be better if you didn't post the log and diffs as attachments

I'd love to do otherwise, but for the moment I've had to become a 
firefox user due to the mailbox constraints at KULeuven. I'm figuring 
how to get mutt back working with IMAP without losing connection all the 
time. But for the moment it'll have to be attachments ;-( Sorry.

>>ctgc.m
>>ctgc.structure_sharing.m
>>ctgc.structure_sharing.analysis.m
>>	New files.
>>
> 
> Presumably there will be anohter package called `structure_reuse'?

Yes indeed.

>>Index: mercury_compile.m
>>===================================================================
>>RCS file: /home/mercury1/repository/mercury/compiler/mercury_compile.m,v
>>retrieving revision 1.363
>>diff -n -r1.363 mercury_compile.m
>>a94 1
>>:- import_module transform_hlds.ctgc.structure_sharing.analysis.
>>d2395 1
>>a2395 4
>>  maybe_dump_hlds(!.HLDS, 192, "dead_procs", !DumpInfo, !IO),
>>
>>   maybe_data_structure_sharing_analysis(Verbose, Stats, !HLDS, !IO),
>>   maybe_dump_hlds(!.HLDS, 193, "structure_sharing", !DumpInfo, !IO),
>>a3692 18
>>   ).
>>
>>:- pred maybe_data_structure_sharing_analysis(bool::in, bool::in,
>>   module_info::in, module_info::out, io::di, io::uo) is det.
>>
>>maybe_data_structure_sharing_analysis(Verbose, Stats, !HLDS, !IO) :-
>>   globals__io_lookup_bool_option(data_structure_sharing_analysis,
>>        Sharing, !IO),
>>   (
>>       Sharing = yes,
>>       maybe_write_string(Verbose, "% Data structure sharing analysis...\n",
>>           !IO),
>>       maybe_flush_output(Verbose, !IO),
>>       % data_structure_sharing_analysis(!HLDS, !IO),
> 
> 
> Although it doesn't (yet) do anything that would be better not commented
> out - at least then we can make sure it compiles.

ok

>>Index: transform_hlds.m
>>===================================================================
>>RCS file: /home/mercury1/repository/mercury/compiler/transform_hlds.m,v
>>retrieving revision 1.20
>>diff -n -r1.20 transform_hlds.m
>>a43 3
>>:- include_module transform_hlds.ctgc.
>>  % :- include_module transform_hlds.ctgc.structure_sharing.
> 
> 
> Why is this here?

gone now.

> 
> 
>>%-----------------------------------------------------------------------------%
>>% Copyright (C) 2005 The University of Melbourne.
>>% This file may only be copied under the terms of the GNU General
>>% Public License - see the file COPYING in the Mercury distribution.
>>%-----------------------------------------------------------------------------%
>>%
>>% File: ctgc.m
>>% Main authors: nancy
>>%
>>% Package regrouping all the modules that are used for compile-time garbage
> 
> 
> s/regrouping/grouping/ and below too.

ok

>>
>>:- module transform_hlds.ctgc.structure_sharing.analysis.
>>
>>:- interface.
>>
>>:- import_module hlds__hlds_module.
>>
>>:- pred data_structure_sharing_analysis(module_info::in, module_info::out,
>>		IO::di, IO::uo) is det.
> 
> 
> s/IO/io/ there unless you mean for the last two arguments to be polymorphic.

*blush*

> 
> 
>>:- implementation.
>>
>>
>>% library modules
> 
> 
> That comment shouldn't be necessary - see the section `Module Imports'
> in the coding standard.


Ok.

See attach,
Nancy


Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: zzreview.start
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20051208/5ce9b089/attachment.ksh>