[m-rev.] for review: fix problems with mmc --make

Julien Fischer juliensf at cs.mu.OZ.AU
Fri Dec 2 17:57:12 AEDT 2005


On Fri, 2 Dec 2005, Julien Fischer wrote:

> > --- compiler/compile_target_code.m	28 Nov 2005 02:30:18 -0000	1.77
> > +++ compiler/compile_target_code.m	2 Dec 2005 05:00:45 -0000
> > @@ -1373,6 +1373,7 @@
> >          globals__io_set_option(use_grade_subdirs, bool(yes), !IO),
> >
> >          io__set_output_stream(ErrorStream, OutputStream, !IO),
> > +        io__remove_file(UserDirFileName, _, !IO),
>
> Don't ignore the result of this call.   Something like the following would
> be better:
>

Ignore that - it suddenly dawned on me why you did it like that.  It would be
good to put in a comment mentioning why it is okay to ignore the return value
though.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list