[m-rev.] for review: work around Darwin PowerPC issue
Zoltan Somogyi
zs at cs.mu.OZ.AU
Tue Aug 16 20:41:37 AEST 2005
On 16-Aug-2005, Ian MacLarty <maclarty at cs.mu.OZ.AU> wrote:
> + % The -floop-optimize option is incompatible with the global
> + % register code we generated on Darwin PowerPC.
s/generated/generate/
> @@ -677,8 +692,9 @@
> NumTagBitsOpt, Target_DebugOpt, LL_DebugOpt,
> DeclDebugOpt, ExecTraceOpt,
> UseTrailOpt, ReserveTagOpt, MinimalModelOpt, TypeLayoutOpt,
> - InlineAllocOpt, " ", AnsiOpt, " ", WarningOpt, " ", CFLAGS,
> - " -c ", C_File, " ", NameObjectFile, O_File], Command),
> + InlineAllocOpt, " ", AnsiOpt, " ", AppleGCCRegWorkaroundOpt,
> + " ", WarningOpt, " ", CFLAGS, " -c ", C_File, " ",
> + NameObjectFile, O_File], Command),
> invoke_system_command(ErrorStream, verbose_commands,
> Command, Succeeded, !IO).
It may be time to reformat that list to put only one option or
group of related options per line.
You also said you wanted -fno-loop-optimize only in LLDS grades; neither
the change to the compiler nor to mgnuc implement that test.
The diff looks fine otherwise, but please test it in both LLDS and MLDS grades
before commit.
Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list