[m-rev.] diff: disable hard_coded/back_external in .profdeep grades

Julien Fischer juliensf at cs.mu.OZ.AU
Wed Aug 3 13:39:52 AEST 2005


Estimated hours taken: 0.1
Branches: main, release

tests/hard_coded/Mmakefile:
	Clean up the handling of disabled tests in the .profdeep
	grades.

	Disable backend_external in the .profdeep grades.  The necessary
	deep profiling data structures haven't been setup for the
	predicates that are implemented with handwritten C code.

	Fix a typo.

Julien.

Index: Mmakefile
===================================================================
RCS file: /home/mercury1/repository/tests/hard_coded/Mmakefile,v
retrieving revision 1.260
diff -u -r1.260 Mmakefile
--- Mmakefile	29 Jul 2005 01:56:59 -0000	1.260
+++ Mmakefile	3 Aug 2005 03:38:17 -0000
@@ -9,7 +9,6 @@
 	address_of_builtins \
 	agg \
 	any_free_unify \
-	backend_external \
 	backquoted_qualified_ops \
 	bidirectional \
 	boyer \
@@ -345,7 +344,7 @@
 #
 # XXX loop_inv_test0, loop_inv_test2:
 #     These test cases test some more sophisticated cases of loop invariant
-#     optimization which are current loop_inv pass is not capable of
+#     optimization which our current loop_inv pass is not capable of
 #     optimizing.
 #
 # XXX var_not_found -- mode error in automatically generated unification
@@ -363,19 +362,26 @@

 # The following tests are passed only in some grades.

-# Deep profiling cannot yet handle exceptions being caught, which the
-# test cases below do.
+# The following tests do not work in the the .profdeep grades.
+# All of them, aside from backend_external, don't work because
+# deep profiling cannot yet handle exceptions being caught and
+# these test cases do that.
+#
+# backend_external fails because the predicates whose implementation
+# is handwritten in C do not have the necessary proc_statics etc,
+# defined.

 ifeq "$(findstring profdeep,$(GRADE))" ""
-	EXCEPTION_PROGS = \
+	NON_PROFDEEP_PROGS = \
 		allow_stubs \
+		backend_external \
 		dir_test \
 		test_array2d \
 		test_injection \
 		user_defined_equality \
 		write_binary
 else
-	EXCEPTION_PROGS =
+	NON_PROFDEEP_PROGS =
 endif

 # compare_representation does not work in the MLDS grades (e.g. hlc.gc),
@@ -469,7 +475,7 @@
 	PROGS = $(JAVA_PROGS) $(JAVA_PASS_PROGS)
 else
 	PROGS = $(ORDINARY_PROGS) $(PROF_PROGS) $(BROKEN_FOR_LCC_PROGS) \
-		$(CLOSURE_LAYOUT_PROGS) $(EXCEPTION_PROGS) \
+		$(CLOSURE_LAYOUT_PROGS) $(NON_PROFDEEP_PROGS) \
 		$(BACKEND_PROGS) $(NONDET_C_PROGS) \
 		$(C_AND_GC_ONLY_PROGS) $(STATIC_LINK_PROGS) \
 		$(CHAR_REP_PROGS) $(C_ONLY_PROGS) \

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list