[m-rev.] for review: fix bugs in mercury_deep_profiling.c

[Julien Fischer]

On Tue, 19 Apr 2005, Zoltan Somogyi wrote:

> For post-commit review by Julien. Any odd indentation is from diff -b.
>
> Zoltan.
>
> runtime/mercury_deep_profiling.c:
> 	Fix two bugs in the code that writes out Deep.data. This required
> 	improving the infrastructure for debugging this module.
>
> 	The first bug involved the management of the table that mapped
> 	the addresses of proc_layout structures (which point to proc statics)
> 	to numerical ids. Of the three places that inserted into this table,
> 	one inserted the address of the proc static structure directly,
> 	leaving dangling proc static ids (ids that don't refer to anything)
> 	in the generated Deep.data file. This caused mdprof to abort
> 	when processing the Deep.data file.
>
> 	To make such bugs less likely in the future, provide type-safe
> 	interface functions to the main functions for manipulating hash tables.
>
> 	The second bug was effectively invisible: the "written" flag wasn't
> 	set on call site dynamic structures as they were written out.
>
> 	Convert the module to four-space indentation to reduce the number of
> 	bad line breaks.
>

That looks fine.

Julien.


--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------