[m-rev.] for review: bug fix in existential constraints

[Julien Fischer]

On Sun, 17 Apr 2005, Mark Brown wrote:

> On 16-Apr-2005, Mark Brown <mark at cs.mu.OZ.AU> wrote:
> > On 15-Apr-2005, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> > > Although it's nothing to do directly with this diff, it looks like
> > > the procedures in hlds_error_util haven't been kept in sync with
> > > the ones in error_util.  In particular, error_util, now prints
> > > out sym_name_and_arities as:
> > >
> > > 	`SymName'/Arity
> > >
> > > whereas in hlds_error_util, they are printed out as:
> > >
> > > 	`SymName/Arity'
> > >
> > > (This only affects the main branch since the change that caused
> > > this was never committed to the release branch).
> >
> > Ok, I'll fix this separately.
>
> ... but which is the correct form?
>

Zoltan changed error_util to use the form `SymName'/Arity in r1.33
of error_util.  The relevant part of the log message for that version
is:

	compiler/error_util.m:
		Add a new version of the utility predicate
		that puts commas and "and"s between elements of a list.

		Fix an old bug: when printing a symname/arity pair,
		put quotes around only the symname part.

> Note that mostly we use `SymName/Arity', for example when printing cons_ids.
> Also, parts of error_util use this form, so error_util itself is inconsistent.
> Personally, I think this form makes more sense anyway, so if there are no
> objections I shall change those parts of error_util back to how they were.
>

Aside from the inconsistency in error messsages I'm not fussed either
way.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------