[m-rev.] for review: bug fix in existential constraints

Mark Brown mark at cs.mu.OZ.AU
Sat Apr 16 01:18:27 AEST 2005


On 15-Apr-2005, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> Although it's nothing to do directly with this diff, it looks like
> the procedures in hlds_error_util haven't been kept in sync with
> the ones in error_util.  In particular, error_util, now prints
> out sym_name_and_arities as:
> 
> 	`SymName'/Arity
> 
> whereas in hlds_error_util, they are printed out as:
> 
> 	`SymName/Arity'
> 
> (This only affects the main branch since the change that caused
> this was never committed to the release branch).

Ok, I'll fix this separately.

> That looks fine otherwise.

I've committed it with the following minor changes.

--- log1	2005-04-16 01:12:25.000000000 +1000
+++ log	2005-04-16 01:13:25.000000000 +1000
@@ -36,3 +36,6 @@
 tests/invalid/quant_constraint_2.m:
 	Test cases for the new error messages.
 
+tests/invalid/unbound_type_vars.err_exp:
+	Update this test case.
+

diff -u tests/invalid/quant_constraint_2.m tests/invalid/quant_constraint_2.m
--- tests/invalid/quant_constraint_2.m	14 Apr 2005 07:33:19 -0000
+++ tests/invalid/quant_constraint_2.m	15 Apr 2005 14:52:25 -0000
@@ -18,7 +18,7 @@
 q = 1.
 
 main(!IO) :-
-	q(X),
+	X = q,
 	write(X, !IO),
 	nl(!IO).
 
only in patch2:
--- tests/invalid/unbound_type_vars.err_exp	14 Feb 2005 08:26:38 -0000	1.3
+++ tests/invalid/unbound_type_vars.err_exp	15 Apr 2005 14:54:35 -0000
@@ -20,4 +20,7 @@
 unbound_type_vars.m:034:   error in type class constraints: type variable `T2'
 unbound_type_vars.m:034:   occurs only in the constraints, not in the
 unbound_type_vars.m:034:   predicate's argument types.
+unbound_type_vars.m:034: In declaration of predicate `unbound_type_vars.p5/1':
+unbound_type_vars.m:034:   type variable T2 is universally constrained, but is
+unbound_type_vars.m:034:   existentially quantified.
 For more information, try recompiling with `-E'.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list