[m-rev.] for review: remove a slow declarative debugger consistency check.

[Ian MacLarty]

For review by anyone.

Estimated hours taken: 0.1
Branches: main and 0.12

Remove the search space consistency check from decide_analyser_response/4.
This check was slowing the declarative debugger down considerably.  The
debugger/declarative/binary_search test now takes about a second or two,
instead of around 5-7 seconds previously (these are estimates).

Also the checks have not failed for several months now.

browser/declarative_analyser.m:
	Remove the search space consistency checks.

Index: browser/declarative_analyser.m
===================================================================
RCS file: /home/mercury1/repository/mercury/browser/declarative_analyser.m,v
retrieving revision 1.22
diff -u -r1.22 declarative_analyser.m
--- browser/declarative_analyser.m	11 Apr 2005 06:43:33 -0000	1.22
+++ browser/declarative_analyser.m	14 Apr 2005 11:42:36 -0000
@@ -465,11 +465,6 @@
 	is det <= mercury_edt(S, T).
 
 decide_analyser_response(Store, Response, !Analyser) :-
-	% Do a sanity check before the search.  So we can determine afterwards
-	% if the search corrupted the search space at all.
-	% XXX this should be removed at some stage as it's relatively slow.
-	check_search_space_consistency(Store, !.Analyser ^ search_space,
-		"Start of decide_analyser_response"),
 	some [!SearchSpace] (
 		!:SearchSpace = !.Analyser ^ search_space,
 		(
@@ -493,12 +488,7 @@
 			handle_search_response(Store, SearchResponse, 
 				!Analyser, Response)
 		)
-	),
-	% Do a sanity check after the search to determine if the search 
-	% corrupted the search space at all. 
-	% XXX this should be removed at some stage as it's relatively slow.
-	check_search_space_consistency(Store, !.Analyser ^ search_space,
-		"End of decide_analyser_response").
+	).
 
 :- pred handle_search_response(S::in, search_response::in, 
 	analyser_state(T)::in, analyser_state(T)::out, 
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------