[m-rev.] Fix a bug in loop invariant hoisting.
Julien Fischer
juliensf at cs.mu.OZ.AU
Fri Apr 8 13:08:45 AEST 2005
On Fri, 8 Apr 2005, Ralph Becket wrote:
> Estimated hours taken: 3
> Branches: main, release
>
> compiler/loop_inv.m:
> Fix a bug in loop invariant hoisting which broke
> tests/valid/loop_inv_bug. It was hoisting goals that
> constructed variables used as (partially) unique inputs
> elsewhere (this is not allowed because of potential
> clobbering). Worse, it was not passing the variables in
> question as invariant arguments.
>
> I've added a comment making explicit the relationship between
> the InvVars and InvGoals variables that must hold for hoisting
> to be sound.
>
That looks ok.
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list