[m-rev.] trivial diff: do not include static_term in ll_backend package

Julien Fischer juliensf at cs.mu.OZ.AU
Tue Apr 5 18:09:25 AEST 2005


On Tue, 5 Apr 2005, Fergus Henderson wrote:

> On 05-Apr-2005, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> > compiler/ll_backend.m:
> > 	Don't include static_term as a submodule of ll_backend
> > 	because it has been deleted.
> >
> > 	XXX I'm not sure why the compiler isn't complaining about
> > 	this.
>
> It is a bit tricky.
>
> There's two cases: using Mmake and using mmc --make.
>
> (1) Using Mmake:
>
> When you delete a module's source file, either directly or via "cvs
> update", the old interface files (static_term.int, static_term.int2
> etc.) stay in the directory.  Mmake will not try to recreate those files
> if they exist and the .m file doesn't exist.  So if you don't re-run
> "mmake depend", the error won't be caught.  That is a reasonable limitation;
> for Mmake, you're supposed to rerun "mmake depend" when source files are
> added or deleted.
>
This was with a fresh workspace, checked out after the file was deleted
so that wasn't the problem.

> If you do run "mmake depend", however, the error is still not caught.
> It appears that there is no check for missing sub-modules.
> Not sure if this is a feature or a bug :)
> But at very least a warning is probably warranted.
>
I vote that it's a bug.


> (2) Using mmc --make.
>
> In this case, the error will be caught.  But the error message is a bit
> confusing.  For example, doing
>
> 	echo ":- include_module y." > x.m
> 	echo > x.y.m
> 	mmc --make x
> 	rm x.y.m
> 	mmc --make x
>
> results in
>
> 	** Error reading file `x.y.m' to generate dependencies:
> 		file `x.y.m' not found.
> 	** Module `x.y' is imported or included by module `x'.
> 	** dependencies for `Mercury/cs/x.y.c' do not exist: x.y.m
> 	** This indicates a bug in `mmc --make'.
>
I'll have a look at that.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list