[m-rev.] for review: mslice and mdice

[Zoltan Somogyi]

On 02-Apr-2005, Ian MacLarty <maclarty at cs.mu.OZ.AU> wrote:
> Please also supply some test cases for the `slice' command and the new sorting
> options.

I will, but probably after committing this; I have another change waiting
for this commit.

> > 	Add a new command, slice, for printing information on slices.
> 
> Will this really be useful from within mdb?

I added it to test the generation of slices before I added mslice. Since
it is now redundant, I will remove it.

> > tests/run_one_test:
> > 	Fix two small bugs in this script: make the filenames more user
> > 	friendly, and make sure that gzip isn't asked to overwrite an
> > 	existing file, since that causes it to ask a question on stdout
> > 	and to wait for an answer.
> > 
> > Index: browser/dice.m
> > ===================================================================
> 
> Should dice.m maybe just be removed altogether?

With CVS, it is hard to resurrect deleted files, so it is safer to leave it.

> > Index: library/list.m
> > ===================================================================
> 
> This file isn't mentioned in the CVS log and map7 and map8 don't seem
> to be used in this diff.

map7 is used in mdbcomp/slice_and_dice.m. I aded map8 at the same time
to save disruption later.

> > Index: mdbcomp/trace_counts.m
> > ===================================================================
> > +    io::di, io::uo) is det.
> > +
> > +:- type slice_source
> > +    --->    file_list
> > +    ;       single_file
> > +    ;       try_single_first.
> > +
> > +:- type read_trace_counts_source_result
> > +    --->    source_ok(set(trace_count_file_type), list(trace_counts))
> 
> Shouldn't this be a list instead of a set?  Surely the caller might want to 
> relate each file type to the trace_counts the file generated?

I have made it an assoc_list.

I have followed your other suggestions.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------