[m-rev.] For review: Made declarative debugger use mdb format settings

Julien Fischer juliensf at cs.mu.OZ.AU
Fri Oct 22 22:00:45 AEST 2004


On Fri, 22 Oct 2004, Ian MacLarty wrote:

> On Fri, Oct 22, 2004 at 06:34:43PM +1000, Julien Fischer wrote:
> >
> > On Thu, 21 Oct 2004, Ian MacLarty wrote:
> >
> > > Made the declarative debugger respect the format settings of the procedural
> > > debugger.  So the print format set in the procedural debugger will be used when
> > > the declarative debugger asks questions and the browse format will be used when
> > > browsing terms in the declarative debugger.  If the user changes the browser
> > > format during a declarative debugging session the procedural debugger will
> > > respect these changes.
> > >
> > I'd suggest rewording the first part of that as follows:
> >
> > Make the declarative debugger respect the format settings of the
> > procedural debugger.  The print format set in procedural debugger will
> > now be used when the declarative debugger asks questions and the browse
> > format will now be used when browsing terms in the declarative debugger.
> >
> Why use "Make" instead of "Made"?  I'm describing the changes I *made* to the
> declarative debugger.

You're describing the changes that you are making to the declarative
debugger, so I wouldn't go with the past tense.  It's a relatively small
matter; my main objection was the second sentence.

> > > trace/mercury_trace_browse.c
> > > trace/mercury_trace_browse.h
> > > 	Exported global which stores the state of the procedural debugger
> > > 	term browser and the function which initialises this state, so they can
> > > 	be used from mercury_trace_declarative.c.
> >
> > s/global/a global variable/
> >
> Changed to : "Exported the global variable which ...".  Using "a" makes it
> sound as if I'm introducing a new variable.
>
> Should I be changing "Exported" to "Export"?
>
It's fine as is.

Cheers,
Julien.


--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list