[m-rev.] For review: Added cdr command to interactive term browser

[Ian MacLarty]

On Fri, Oct 22, 2004 at 02:44:25PM +1000, Julien Fischer wrote:
> 
> On Fri, 22 Oct 2004, Ian MacLarty wrote:
> 
> >  "\tcd [path]      -- cd to the specified subterm (default is root)\n",
> > +"\tcdr n path     -- repeatedly cd's into the path n times\n",
> 
> Is using an apostrophe to denote the plural of cd the correct thing to do
> there?  (And in the log message as well).
> 

+"\tcdr n path     -- repeatedly apply the cd command n times\n",

cdr's arguments are not optional, so not in brackets.

Technically I don't think you're supposed to use an apostrophe for acronym
plurals, so I changed the CVS comment to: "This repeatedly cds ..."

> 
> I think you should add a test where you try to cdr into
> an invalid location as well.
> 
--- tests/debugger/browser_test.exp	13 May 2004 08:50:31 -0000	1.17
+++ tests/debugger/browser_test.exp	22 Oct 2004 10:14:38 -0000
@@ -94,6 +94,17 @@
   big(big(small, 1, small), 2, small), 
   3, 
   big(big(small, 4, big(small, 5, small)), 6, small))
+browser> cdr 100 2
+error: in subdir 2: there is no subterm 2
+browser> cdr 3 1
+browser> ls
+small
+browser> cdr 3 ../1/..
+browser> ls
+big(
+  big(big(small, 1, small), 2, small), 
+  3, 
+  big(big(small, 4, big(small, 5, small)), 6, small))
 browser> quit
 mdb> set -A -f depth 1


--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------