[m-rev.] For review: Fix seg fault bug in declarative debugger.

[Julien Fischer]

On Wed, 24 Nov 2004, Ian MacLarty wrote:

> On 24 Nov 2004, at 15:29, Julien Fischer wrote:
>
> >
> > On Wed, 24 Nov 2004, Ian MacLarty wrote:
> >
> >>>>> Are MR_TRUE and MR_FALSE always going to be the same as yes and no?
> >>>>
> >>>> The original reason why we used ML_bool_return_{yes,no} instead of
> >>>> constants
> >>>> was the .rt grade, which we don't support anymore.
> >>>
> > A general question: is there any point in keeping ML_bool_return{yes,
> > no}
> > then?
>
> It doesn't seem to be used anywhere else besides in
> extras/graphics/{mercury_opengl,mercury_glut}, however I'd feel
> uncomfortable just removing it as other software written in Mercury may
> use it.
>
The graphics stuff is easily fixed so that's not really an objection.

> >
> >> I added the following comments to runtime/mercury_std.h and
> >> library/bool.m:
> >>
> >> Index: library/bool.m
> >> ===================================================================
> >> RCS file: /home/mercury1/repository/mercury/library/bool.m,v
> >> retrieving revision 1.9
> >> diff -u -r1.9 bool.m
> >> --- library/bool.m	22 May 2003 03:54:39 -0000	1.9
> >> +++ library/bool.m	24 Nov 2004 03:16:23 -0000
> >> @@ -58,6 +58,12 @@
> >>
> >>  :- implementation.
> >>
> >> +%
> >> +% Important:
> >> +% The representation of bool values should correspond with the
> >> definitions of
> >> +% MR_TRUE and MR_FALSE in runtime/mercury_std.h.
> >> +%
> >> +
> > They are also defined in runtime/mercury_bootstrap.h as well.  You
> > should
> > mention that as well.
>
> Only TRUE and FALSE are defined there as aliases for MR_TRUE and
> MR_FALSE, so I don't think a comment is necessary.
>
You're right; I couldn't remember exactly what was in that header.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------