[m-rev.] For review: Trust standard library

Julien Fischer juliensf at cs.mu.OZ.AU
Wed Nov 10 19:16:57 AEDT 2004


On Wed, 10 Nov 2004, Ian MacLarty wrote:

> On Wed, Nov 10, 2004 at 05:30:41PM +1100, Julien Fischer wrote:
> >
> > On Wed, 10 Nov 2004, Ian MacLarty wrote:
> >

> > > +:- pred format_trust_command(trusted_object::in, string::in,
> > > +	string::out) is det.
> > > +
> > > +format_trust_command(module(ModuleName), S, S++"trust "++ModuleName++"\n").
> > > +format_trust_command(predicate(ModuleName, Name, Arity), S, S++Command) :-
> > > +	ArityStr = int_to_string(Arity),
> > > +	Command = "trust pred*"++ModuleName++"."++Name++"/"++ ArityStr++"\n".
> > > +format_trust_command(function(ModuleName, Name, Arity), S, S++Command) :-
> > > +	ArityStr = int_to_string(Arity - 1),
> > > +	Command = "trust func*"++ModuleName++"."++Name++"/"++ ArityStr++"\n".
> > > +format_trust_command(standard_library, S, S++"trust std lib\n").
> > >
> > I'd leave some space around the ++ operator there. (And elsewhere in this
> > diff).
> >

I still think that's worth doing.
Otherwise that's fine.B

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list