[m-rev.] for post-commit review: compiling modules with fact tables

[Julien Fischer]

On Fri, 19 Mar 2004, Zoltan Somogyi wrote:

> This is for review by Simon or Fergus after commit.
>
> Zoltan.
>
> A single invocation of mmc should suffice to compile a single-module program.
> Previously this was true only if the program did not use fact tables; this
> change makes it true even for programs using fact tables. The motivation
> is the change to tests/tabling/sg.m, and the need for the convenience of
> continuing to be able to compile it with a single command during development.
>
...
>
> compiler/compile_target_code.m:
> 	Link fact table object files into the executable.
>
> cvs diff: Diffing compiler
> Index: compiler/compile_target_code.m
> ===================================================================
> RCS file: /home/mercury/mercury1/repository/mercury/compiler/compile_target_code.m,v
> retrieving revision 1.55
> diff -u -b -r1.55 compile_target_code.m
> --- compiler/compile_target_code.m	19 Mar 2004 10:19:19 -0000	1.55
> +++ compiler/compile_target_code.m	18 Mar 2004 15:15:53 -0000
>
...
>  	% get_object_code_type(TargetType, PIC)
>  	%
> @@ -157,12 +158,12 @@
>
>  :- import_module backend_libs__foreign.
>  :- import_module backend_libs__name_mangle.
> +:- import_module hlds__error_util.
>  :- import_module hlds__passes_aux.
>  :- import_module libs__globals.
>  :- import_module libs__handle_options.
>  :- import_module libs__options.
>  :- import_module libs__trace_params.
> -:- import_module parse_tree__error_util.
>  :- import_module parse_tree__prog_out.
>
>  :- import_module char, dir, getopt, int, require, string.
> @@ -808,7 +809,7 @@

This diff seems to have undone part of the change you made earlier.
I've committed the following in order to fix this.


Estimated hours taken: 0.1
Branches: main

compiler/compile_target_code.m:
	Import parse_tree.error_util not hlds.error_util.
	The latter was renamed as the former.

Index: compile_target_code.m
===================================================================
RCS file: /home/mercury1/repository/mercury/compiler/compile_target_code.m,v
retrieving revision 1.56
diff -u -r1.56 compile_target_code.m
--- compile_target_code.m	19 Mar 2004 11:13:14 -0000	1.56
+++ compile_target_code.m	19 Mar 2004 13:00:56 -0000
@@ -158,12 +158,12 @@

 :- import_module backend_libs__foreign.
 :- import_module backend_libs__name_mangle.
-:- import_module hlds__error_util.
 :- import_module hlds__passes_aux.
 :- import_module libs__globals.
 :- import_module libs__handle_options.
 :- import_module libs__options.
 :- import_module libs__trace_params.
+:- import_module parse_tree__error_util.
 :- import_module parse_tree__prog_out.

 :- import_module char, dir, getopt, int, require, string.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------