[m-rev.] for review: use proc layouts in annotated trace

[Zoltan Somogyi]

On 30-Jun-2004, Ian MacLarty <maclarty at cs.mu.OZ.AU> wrote:
> +		(ProcId = proc(_, _, _, ProcName, _, _)
> +		;ProcId = uci_proc(_, _, _, ProcName , _, _)), 

This code should be factored out to a separate predicate.

> +			proc_label		:: proc_layout,

proc_layout would seem to be a better field name.

> +:- pred add_atom_to_ground_map(decl_truth::in, final_decl_atom::in, 
> +	proc_layout::in, map_cc(final_decl_atom, decl_truth)::in,
> +	map_cc(final_decl_atom, decl_truth)::out) is det.
> +
> +add_atom_to_ground_map(Truth, FinalAtom, ProcLayout, Map0, Map) :-
> +	Map = promise_only_solution(

You shouldn't need the promise_only_solution, since add_atom_to_ground_map
should be cc_multi.

Otherwise, the diff is fine.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------