[m-rev.] For review: Library Mmakefile for grade Java

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Jan 27 06:15:07 AEDT 2004


On 23-Jan-2004, James Goddard <goddardjames at yahoo.com> wrote:
> +ifneq (,$(findstring java,$(GRADE)))
> +
> +JAVA_LIBRARY_INSTALL_PATH = $(INSTALL_PREFIX)/lib/mercury/lib/java

That variable should be defined in scripts/Mmake.vars.in
rather than library/Mmakefile, along with the other INSTALL_*_DIR
variables, and for consistency with their naming scheme should be named
INSTALL_JAVA_LIBRARY_DIR or something like that.

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list